Skip to content

Replace logo.png by logo.svg#249

Merged
m7pr merged 2 commits intomainfrom
svg_logo@main
Dec 23, 2024
Merged

Replace logo.png by logo.svg#249
m7pr merged 2 commits intomainfrom
svg_logo@main

Conversation

@llrs-roche
Copy link
Contributor

@llrs-roche llrs-roche commented Dec 20, 2024 •
edited by m7pr
Loading

What changes are proposed in this pull request?
Uses svg logo instead of the png to reduce package size

This is in reference to insightsengineering/nestdevs-tasks#93
The logo was generated with the script at: insightsengineering/hex-stickers#39

Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@llrs-roche
Copy link
Contributor Author

llrs-roche commented Dec 20, 2024

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche llrs-roche changed the title Svg logo@main Replace logo.png by logo.svg Dec 20, 2024
@llrs-roche llrs-roche mentioned this pull request Dec 20, 2024
Closed
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Unit Tests Summary

  1 files  158 suites   1m 8s ⏱️
156 tests 122 ✅ 34 💤 0 ❌
569 runs  523 ✅ 46 💤 0 ❌

Results for commit ac93ca7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

badge

Code Coverage Summary

Filename                                Stmts    Miss  Cover    Missing
------------------------------------  -------  ------  -------  -----------------------------------
R/add_total_n.survey.design.R              12       0  100.00%
R/ard_aod_wald_test.R                      77       8  89.61%   38-43, 93, 96
R/ard_attributes.survey.design.R            2       0  100.00%
R/ard_car_anova.R                          45       2  95.56%   62, 65
R/ard_car_vif.R                            62       1  98.39%   87
R/ard_categorical_ci.R                     96       1  98.96%   83
R/ard_categorical_ci.survey.design.R      129       1  99.22%   180
R/ard_categorical.survey.design.R         393       8  97.96%   77, 228-231, 275, 517, 531
R/ard_continuous_ci.R                      28       1  96.43%   38
R/ard_continuous_ci.survey.design.R       138       0  100.00%
R/ard_continuous.survey.design.R          274      14  94.89%   86, 177, 187, 338, 369-370, 418-426
R/ard_dichotomous.survey.design.R          73       3  95.89%   51, 156, 161
R/ard_effectsize_cohens_d.R               103       2  98.06%   69, 122
R/ard_effectsize_hedges_g.R                91       2  97.80%   68, 120
R/ard_emmeans_mean_difference.R            70       0  100.00%
R/ard_missing.survey.design.R              79       1  98.73%   52
R/ard_regression_basic.R                   16       1  93.75%   46
R/ard_regression.R                         73       0  100.00%
R/ard_smd_smd.R                            69       5  92.75%   57, 83-86
R/ard_stats_anova.R                        95       0  100.00%
R/ard_stats_aov.R                          46       0  100.00%
R/ard_stats_chisq_test.R                   40       1  97.50%   39
R/ard_stats_fisher_test.R                  43       1  97.67%   42
R/ard_stats_kruskal_test.R                 36       1  97.22%   38
R/ard_stats_mcnemar_test.R                 80       2  97.50%   63, 106
R/ard_stats_mood_test.R                    49       1  97.96%   45
R/ard_stats_oneway_test.R                  39       0  100.00%
R/ard_stats_poisson_test.R                 76       1  98.68%   59
R/ard_stats_prop_test.R                    85       1  98.82%   43
R/ard_stats_t_test_onesample.R             41       0  100.00%
R/ard_stats_t_test.R                      112       2  98.21%   65, 111
R/ard_stats_wilcox_test_onesample.R        42       0  100.00%
R/ard_stats_wilcox_test.R                  99       2  97.98%   65, 117
R/ard_survey_svychisq.R                    38       1  97.37%   44
R/ard_survey_svyranktest.R                 54       1  98.15%   44
R/ard_survey_svyttest.R                    53       1  98.11%   42
R/ard_survival_survdiff.R                  89       0  100.00%
R/ard_survival_survfit_diff.R              76       0  100.00%
R/ard_survival_survfit.R                  197       5  97.46%   211-215
R/construction_helpers.R                  106      10  90.57%   160-175, 189, 248
R/proportion_ci.R                         195       1  99.49%   454
TOTAL                                    3521      81  97.70%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ac93ca7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_categorical.survey.design 💔 $17.26$ $+2.73$ ard_categorical.survey.design_works
ard_continuous.survey.design 💔 $12.91$ $+2.87$ unstratified_ard_continuous.survey.design_works
ard_survival_survfit 💚 $2.63$ $-1.03$ ard_survival_survfit_works_with_times_provided
construction_helpers 💚 $2.39$ $-1.96$ construct_model_works
proportion_ci 💚 $1.63$ $-1.48$ check_the_proportion_ci__functions_work

Results for commit e324642

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit a2bd13d into main Dec 23, 2024
33 checks passed
@m7pr m7pr deleted the svg_logo@main branch December 23, 2024 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Dec 23, 2024

@m7pr @llrs-roche this PR was meant to reduce sizes of logos? It appears we replaced a 46KB PNG with a larger 62KB SVG (both small file size)? I often source these logos directly into presentations. In the past (years ago at this point), I had an issue rendering SVGs into a reaveal js slide deck. Have you seen any of those issues recently?

@llrs-roche
Copy link
Contributor Author

llrs-roche commented Jan 7, 2025

Hi @ddsjoberg, in principle this PR is to reduce logo size. I didn't realize that the svg is 20kb bigger than the png (in all the other changes I checked was always lower). But using the svg will make it consistent with other packages on the organization, feel free to revert the commit though.

I haven't seen any issues with svg files recently (I think that once with Power Point several years ago). All logos, png, svg and jpeg are (or will be) at https://github.com/insightsengineering/hex-stickers so you will be able to source the logos in other formats from there if you wish.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m7pr m7pr m7pr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llrs-roche @ddsjoberg @m7pr